This repository was archived by the owner on Apr 28, 2025. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 55
Support Alertmanager HA #147
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    cstyan
  
              
              reviewed
              
                  
                    Jul 25, 2020 
                  
              
              
            
            
              
                    cstyan
  
              
              reviewed
              
                  
                    Jul 25, 2020 
                  
              
              
            
            
              
                    jtlisi
  
              
              approved these changes
              
                  
                    Jul 30, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
        
          
                cortex/config.libsonnet
              
                Outdated
          
        
      | }[$._config.ruler_client_type], | ||
|  | ||
| alertmanager: { | ||
| replicas: 1, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still going to default to 1 replica?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, can we bump this to 3?
              
                    gouthamve
  
              
              approved these changes
              
                  
                    Aug 31, 2020 
                  
              
              
            
            
With this, we can now support increasing the number of replicas for a Cortex AM thus enabling HA. Please note that Alerts themselves are not gossiped between Alertmanagers. Each Ruler needs to send the alert to every Alertmanager available thus the reason why a headless service gets created when the number of replicas is more than 1.
b16637a    to
    69af294      
    Compare
  
    
      
        
      
      
  
    1 task
  
    
  simonswine 
      pushed a commit
        to grafana/mimir
      that referenced
      this pull request
    
      Dec 20, 2021 
    
    
      
  
    
      
    
  
Support Alertmanager HA
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
With this, we can now support increasing the number of replicas for a
Cortex AM thus enabling HA.
Please note that Alerts themselves are not gossiped between
Alertmanagers. Each Ruler needs to send the alert to every Alertmanager
available thus the reason why a headless service gets created when the
number of replicas is more than 1.